Hi Moritz,

Thanks for your reply. However, I still can't get it to work.

I have defined all variables, I use strict and warnings. I have changed the lines for opening the in and out files to

   open (my $in,"<$file") or die "Can't open file '$file' for reading:
+ $!";
   open (my $out,">$file.out") or die "Can't open file '$file.out' for
+ writing: $!";
[download]

because otherwise it gave me this error:

Unsuccessful open on filename containing newline at test.pl line 18
[download]

With your alterations my program looks like this:

use strict;
use warnings;
my $echo="ECHO";
my $value=undef;
my $key=undef;
my %lijst=();
open (DFFILE,$ARGV[0]) || die "DF-file not found\n";
open (LIST,$ARGV[1]) || die "List not found\n";
while (<DFFILE>) {
    ($value, $key) = split(/\t/, $_);
    $lijst{$key} = $value;
}
my @listfiles = <LIST>;
my $all_words_regex = join '|', keys %lijst;
for my $file (@listfiles) {
   open (my $in,"<$file") or die "Can't open file '$file' for reading:
+ $!";
   open (my $out,">$file.out") or die "Can't open file '$file.out' for
+ writing: $!";
   while (<$in>){
       if (m/^($all_words_regex)/){
           my $first_word = $1;
           s/$first_word/$echo/g;
           s/$echo/$first_word/;
       }
       print $out $_;
   }
}
close(DFFILE);
[download]

But this gives me the exact same result as it did without your alterations. Or am I doing something wrong?

Also, I realize I left out one aspect of my program. The substitution only needs to be done when the value of the hash key is 1.

Matje

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.