Sorry, but your script has hideous security holes and will be easily subverted to send spam.

Please use a form mailer script like the NMS Formmail Script, which has been vetted.

Why are you using CGI and still doing manual parameter decoding in your parse_form_data subroutine? Simply use CGI::param() instead.

Your handling of form parameters opens up lots of backdoors to send spam, because it is very easy to embed newline characters (or other characters relevant to the protocol how sendmail expects it) into for example the $from variable. This is a large security hole that will likely put your machine onto a mail blacklist within a few days. To fix that, you need to verify that all your input data is as you expect it to be, especially that your $from email address does only contain the characters you expect. Possibly, only allowing /[-+\@.\w]+/ would be a crude yet effective filter.

Your copy-and-paste of the source code used weird "matching" quotes that Perl 5 does not understand.

In reply to Re: Perl script to send form data via email by Corion
in thread Perl script to send form data via email by gugubanana

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.