I assume you tested your script, and it works like expected.

As to the matter of style, I can strongly recommend to properly indent your code, one tab (or 4 or 8 spaces or whatever) per opening bracket. That way you'll actually see what it's doing.

Secondly I suggest you use lexical variables as file handles, and use the three-argument for of open. See perlopentut for more details.

See perlstyle for more tips on how to make your code readable.

If you want more in-depth analysis of your script, install Perl::Critic, it might give you some helpful at wise.

Now I can only recommend that you read Writeup Formatting Tips and update your posting to use paragraphs for text, and code tags only for code.

Helping with homework isn't much fun, btw.


In reply to Re: Analysing text files to obtain statistics on their content. by moritz
in thread Analysing text files to obtain statistics on their content. by Davo1977

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.