Add the following to the top:
use strict;
use warnings FATAL => 'all';
Fix all the problems that arise. Your problems will be much clearer now.
As for your code, there are modules that deal with that. You really don't want to use eval. If you can't use modules for some reason, here's a version that should work for you (untested!):
sub get_numbers_from_ranges {
my $spec = shift;
my %numbers;
foreach my $x ( split ',', $spec ) {
if ( $x =~ /(\d+)-(\d+)/ ) {
$numbers{$_} = undef for $1 .. $2;
}
else {
$numbers{$x} = undef;
}
}
return map { $_ - 1 } sort { $a <=> $b } keys %numbers;
}
My criteria for good software:
- Does it work?
- Can someone else come in, make a change, and be reasonably certain no bugs were introduced?
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.