Dear monks,
I am trying to write a script that will identify the presence of certain terms in a large number of entered text messages. I am experiencing time efficieny problems and would like to know if I could have done anything better.
The core of the code, which is the slow part, looks virtually like this:
...
sub slow_match {
my($hash_ref_1,$hash_ref_2) = @_;
while ( my($pattern,$high_lvl_id) = each(%hash1) ) {
my $match = qr/\b$pattern\b/;
while ( my($text_id,$text) = each(%hash2) ) {
if ($text =~ $match) {
$$hash_ref_1{$text_id} .= ':'.$high_lvl_id;
foreach my $part (split(/\s/,$pattern)) {
$$hash_ref_2{$text_id} -> {$part} = 0;
}
}
}
}
}
...
There are in the order of 20,000 texts and 50,000-100,000 patterns, and there is only on average about 1 pattern matching each text.
The script runs in roughly 1.5 hours on my server, which I was hoping to improve. Using the qr// did improve it very much, but perhaps it could be even better.
Many thanks,
Ola
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.