Hi, I'm a beginner in perl and I made some code to clean log files. But the speed isn't fast enough. So I was wondering if a more advanced user could change it a little. Thx in advance
#!/usr/bin/perl use warnings; use strict; use Term::ReadKey; print "[-] Enter the filename: "; chomp($file = <STDIN>); open(LIST,$file); @file1 = <LIST>; close(LIST); if (-e "cleaned.txt") { print "[-] Can cleaned.txt be deleted? "; $answer = <stdin>; if ($answer =~ /yes/i) { unlink "cleaned.txt"; } else { &exit } } print "[-] Cleaning...\n"; foreach $data (@file1) { ($w1) = split(/:/,$data); open(OUTPUT,">>cleaned.txt"); print OUTPUT $w1."\n" unless ($data =~ /-/); close(OUTPUT); } &exit; sub exit() { ReadMode 2; print "\n[-] Press ENTER to exit..."; <STDIN>; exit; }
edit: Sorry people. I just saw that I posted this in the wrong section. Can a mod please move this.

In reply to Increase speed script by marto9

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.