marto9:

I believe that the primary speed problem is due to you opening and closing the output file in your cleaning loop. You should open the file before starting the loop, then write out all your data, and close at the end:

print "[-] Cleaning...\n";
open(OUTPUT,">>cleaned.txt") or die "Can't open cleaned.txt!";
foreach $data (@file1) {
    ($w1) = split(/:/,$data);
    print OUTPUT $w1."\n" unless ($data =~ /-/);
}
close(OUTPUT) or die "close error";
[download]

A couple of minor items:

• Always check your file operations (the or die "msg" bits above) to ensure that they were successful.
• If cleaned.txt is a "valuable" file, you should probably delete it only after successfully building your new one. You could, for example, build the file as cleaned.txt.tmp. Then, only after the final close is successful, you could rename cleaned.txt to cleaned.txt.bak and then rename cleaned.txt.tmp to cleaned.txt.

...roboticus

UPDATE: Fixed a bit of awkward grammar, added some formatting for readability.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.