I don't know if your code is correct or not, but it's certainly more complex than it needs to be.

Here's how I'd built the frequency statistics: 

use POSIX qw(floor);
sub build_histogram {
   my ($bucket_size, @items) = @_;
   my %result;
   for (@items) {
       my $bucket = $bucket_size * floor($_ / $bucket_size);
       $result{$bucket}++;
   }
   return %result;
}

[download]

This sorts everything from 0 to $bucket_size (exlusively) into the first bucket labeled 0 etc. If you want it to be sorted into a bucket labeled $bucket_size instead, use ceil() instead of floor().

Anyway, it's hard to tell if your code is correct or not. Try to use Data::Dumper to check if the intermediate data structures are correct, and perhaps even do it manually for a short excerpt of the log files and compare the results.

In reply to Re: Working out frequency statistics with perl by moritz
in thread Working out frequency statistics with perl by wishartz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.