Can someone please take a look at the below script to review it for any flaws or suggestions that would make it a rock solid script. You will notice I put another find to compare against the original. Thanks, Dave
#!/usr/bin/perl -w #use strict; use File::Find; use File::stat; my @results; my $ext = "A"; find(\&search, "c:/test"); sub search { if ($_ =~ m/ACH/ ) { push @results, [$_, stat($_)->mtime, stat($_)->size]; } } @results = sort { $a->[1] <=> $b->[1]} @results; foreach my $x (@results){ rename ($x->[0], "USB" . $ext); print $x->[0] . "\t" . localtime($x->[1]) . $x->[0]->size ."\n"; ++$ext; } my @temp; find(\&post, "c:/test"); sub post { if ($_ =~ m/USB/ ) { push @temp, [$_, stat($_)->mtime]; } } foreach my $y (@temp) { print $y->[0] . "\t" . localtime($y->[1]) . "\n"; }

In reply to Script Critique by drodinthe559

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.