For counterpoint, using our is perfect for the OP's task.

By lexically scoping all his wide-scoped package vars, and reducing their visibility to just those places where they are used--prior to splitting the monolithic script into modules--it becomes far easier to identify which variables have to be passed to what subroutines. And that makes the second stage of the process, passing them as parameters, far easier.

As an intermediate step in a refactoring process, lexically scoping the globals is far better than C&Ping the same a huge block of global declarations at the top of every module.

Lexically scope them in the big file first. Make sure everything still works. Split the function into modules--perhaps using the new found knowledge of what routines are dependant upon which globals as an aid to deciding what should go with what--and check again everything still works. Then set about passing those variables through parameters. A totally sane and logical refactoring process.

And for singletons they are perfect too. Even if you do leave them declared at the package scope level.


Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.
"Too many [] have been sedated by an oppressive environment of political correctness and risk aversion."

In reply to Re^2: My globals are visable; but undef'ed by BrowserUk
in thread My globals are visable; but undef'ed by Wiggins

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.