That code could be prettier, but it has a serious bug in it:

    # if you want to delete, make the line with null value;

    $data[$line] = "";

[download]

This doesn't actually delete the line; it replaces it with an empty line. Oh, and there's another bug -- why join lines on newlines when you haven't chomped away existing newlines? Here's much better code:

my $filename = 'yourfilename.txt';
my $newfile  = 'new_filename.txt';

filter_file( $filename, $newfile );

# this line may be unnecessary depending on your filesystem
unlink $filename;
rename( $filename, $newfile );

sub filter_file
{
    my ($from, $to) = @_;
    open my $fh,          $from or die "Can't read '$from': $!\n";
    open my $out_fh, '>', $to   or die "Can't write '$to': $!\n";

    while (<$fh>)
    {
        next if should_delete_line($_);
        print {$out_fh};
    }
}

[download]

In reply to Re^2: How to delete the line I have just read? by chromatic
in thread How to delete the line I have just read? by ademmler

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.