Whoops, that's what happens when you submit code without testing it first :). There were four things wrong with my code:
- The open call for the MIXED file did not have a '>'. This is sheer carelessness.
- I was openning the files to the same typeglob, which resulted in three references to the same open file being stored in the array. This is a more subtle bug.
- I was testing for eof after reading in a line, instead of before. This would result in the last line never being written to the mixed file.
- Finally, I was using 'last' within the inner loop, foolishly thinking it would get me out of the outer loop. Another dumb mistake.
Working code (at least on my Wintel box) follows:
my @files = ("1.txt", "2.txt", "3.txt");
my @fhs;
for ($i = 0; $i < scalar(@files); ++$i) {
open($fhs[$i], $files[$i]) || die;
}
open(MIXED, ">mixed.txt") || die;
OUTER:
while (1) {
foreach $fh (@fhs) {
last OUTER if (eof($fh));
$line = <$fh>;
print MIXED $line;
}
}
map { close($_); } @fhs;
close(MIXED);
Let this be a lesson for me in preliminary testing!
-ton
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.