You've used good variable names, but there are no comments.

I personally believe that this can (i.e. please don't think I'm claiming it necessarily is) just as good as it gets: if comments add nothing and the code is pretty much self explanatory, then one should plainly not add them.

you don't need either the exit or the __END__ at the end of your script.

While the unnecessary exit is very unperlish, I'm sorry to have to repeat myself (because I don't feel like going and have a Super Search but I'm sure I'd find tons of previous remarks of the same kind...) but __END__ is pretty much like a "bye" and pairs nicely with the "hello" given by the shebang line: this is a remark not of my own but heard from $Larry himself, and I pretty much was fond of it as soon as I heard it for the very first time.

--
If you can't understand the incipit, then please check the IPB Campaign.

In reply to Re^2: sortmd5 script by blazar
in thread sortmd5 script by mscharrer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.