Dear Perl Monks,

The script I'm writing opens a data file I've already constructed, using it to create a hash. Next, it opens a directory of .gif files, reads the directory contents into an array, and closes the directory. Then, it uses the hash to search and replace on the array. When I print the array to STDOUT, I get a satisfactory list. The script creates a new directory. I want the new directory to contain new .gif files, renamed according to the search and replace. I tried to pump the contents of the array into the new directory. The script seems to execute, but I end up with a new, but empty directory.

open IMAGEHASH, "results.txt" or die "Couldn't open file:$!";

my %image_hash = ( );
my $search = undef;
my $replace = undef;

while (<IMAGEHASH>) {
    ($search, $replace) = ($_=~m/(.*) (.*)/);
       if ($search ne '' && $replace ne '') {
              $image_hash{$search} = $replace;
    }
}

opendir (GIFDIR, "/home/tony/perl/pmbencor") || die ("Cannot open dire
+ctory.");
my @the_files = grep { $_ ne '.' && $_ ne '..' } readdir(GIFDIR); 
closedir GIFDIR;

foreach my $file (@the_files) {
    foreach $key (keys %image_hash) {
        $file=~ s/$key/$image_hash{$key}/g;    
    }
}

mkdir ("newdir", 0777) || print $!;
opendir (NEWDIR, "/home/tony/perl/newdir") || die ("Cannot open direct
+ory.");

use Cwd;
my $here = cwd;
my $there = '/home/tony/perl/newdir';

use File::Copy;
foreach my $file (@the_files) {move ($here, $there)}
closedir NEWDIR;

[download]

It seems to me there's a problem with the last six lines of code...I learned how to open, read and close directories from a search of the archives, but this has brought me up short...Thanks for your help!

In reply to How do I move array contents into a directory? by tonyz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.