Starting after your %image_hash setup:

my $gifdir_name = "/home/tony/perl/pmbencor";
opendir my $gifdir_dh, $gifdir_name
    or die "Can't opendir '$gifdir_name': $!";
my @orig_files = grep { !/^\.\.?$/ } readdir $gifdir_dh;
closedir $gifdir_dh;

my $there = '/home/tony/perl/newdir';
mkdir $there, 0777  or die "Can't mkdir $there: $!";

my $key_pattern = join '|', map { quotemeta } keys %image_hash;

use File::Copy;  # this should really be at the top somewhere

foreach my $file (@orig_files) {
    my $new_name = $file;
    $new_name =~ s/($key_pattern)/$image_hash{$1}/g;
    move "$gifdir_name/$file", "$there/$new_name"
        or die "Can't move '$file' to '$new_name': $!";
}
[download]

Notes:

• You may want to grep out all files that start with a dot, not just "." and "..". In that case, just use !/^\./.
• I don't think "$there" is a very good variable name (but I haven't changed it).
• Your original code treated the %image_hash keys as patterns (that is, a key of "^" would have matched anything), but my code treats them as literal strings. If you want the pattern behavior, change the quotemeta map to "map { "(?:$_)" }".
• Given "%image_hash = ( x => 'y', y => 'z' )", your code could have done two replacements on an "x", changing it to "z" (but not definitely). Mine will only do one replacement.
• If you have "%image_hash = ( abc => 'x', abcd => 'y' )", and the $file is "abcd", I'm not sure which will match. If that's a concern, you may want to go back to a replacement loop and sort according to length or something.
• Since your source and destination directories are on the same drive, you could use rename instead of move
• I haven't tested what I wrote.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.