while ($s)
should be
while (length($s))

I personally believe that you're partially right: after all I may end up with $s eq "0"! D'oh! But then length would leave me with an uninitialized warning on the last iteration. Thus I'd use defined instead: worse luck, if it were not for 0 being a valid octal digit, I wouldn't have needed it in !defined $s above, either!

It would also be nice if the wrapping occurs after at most 60 characters, instead of after at least 60 characters (with no maximum!)

You're probably right: but to be fair, the splitting was more of an afterthought than anything else. I was primarily concerned with the conversion, and I hope not to have left errors there. (Now, if I had some spare time, I would make this into a Perl string literal converter, and then use eval to check... Perhaps, after lunch I'll do! ;)

--
If you can't understand the incipit, then please check the IPB Campaign.

In reply to Re^2: Simple binary data to JS string literal converter by blazar
in thread Simple binary data to JS string literal converter by blazar

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.