Thanks for your comments. I should probably give some longcalls explanation.

Code sample given is a simplified but real world example: $file encapsulates a binary file (log) produced by a phone switch. It contains cdrs (Call Data Records) describing voice calls carried out. The file is used as a source for several target applications (billing, dwh).

If a call continues longer than say half an hour it is logged by parts. If join_longcalls is set for open_for_reading only complete calls are produced by read_cdr and the total duration of the call is summed up.

So the join_longcalls flag really causes the long calls to be joined. In such case I am not sure whether to use join_long_calls or joins_long_calls?

I think open_for_reading is clearer than plain reading since I try to use imperative for my subs.

As kyle suggested, I could avoid some of the "SUPERs" and turns the code into:

my $context = $file->open_for_reading({'path' => $path});
$context->joins_long_calls(1); 
# or better like this, 
# because there is no property join_long_calls
$context->join_long_calls;
[download]

The open_for_reading, actually returns Class::Prototyped based object, so join_longcalls - whatever its implementation is - actually wraps read_cdr method.

This approach has some advantages:

• The interface of open_for_reading remains same across classes.
• It is more self checking - since the parameters were turned into method calls, which fail when called but not defined.

This approach has also some disadvatages:

• Although $lc->join_long_calls can be called anytime, it make sense only immediately after open.
• When I have target file (representation of the billing, dwh file) I could have previously used a declaratory source_params method containing the parameters to be passed to open_for_reading, now I had to redefine some open_source method.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.