You are right. I missed the fact that each element in the comment (is it really a comment?) ticks over indvidually.

The good news is that it's easy enough to modify my code to support that behavior. 

my @current_version = split_version($old_version);
my @commands = map {
    if( $updated[$_]) {
            # did we update this field?
        my $current_version = join '.', @current_version;
        $current_version[$_] = $new_version[$_];
        update_aht_command(   # if so, generate a command
            (KEYWORDS)[$_], 
            $new_version[$_], 
            "#DBVersion=$current_version",
         )
    }
    else {     # otherwise put nothing in the command list. 
         ();
    }
} VERSION_ELEMENTS;

[download]

The bad news is that I've now got code with side-effects in my map block. Yuck.

So in this case I'd probably refactor and use a foreach to iterate my arrays. 

my @current_version = split_version($old_version);
my @commands;
foreach my $part ( VERSION_ELEMENTS ) {
    if( $updated[$part]) {    # did we update this field?
        
        my $current_version = join '.', @current_version;

        $current_version[$part] = $new_version[$part];

        push @commands, update_aht_command( 
            (KEYWORDS)[$part], 
            $new_version[$part], 
            "#DBVersion=$current_version",
         )
    }
}

[download]

Warning: I edited this code in the text box on this page and I haven't tested it, it probably has typos, fleas and other bugs.


TGI says moo

In reply to Re^3: Trying to avoid 9 conditionals by TGI
in thread Trying to avoid 9 conditionals by techsan02

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.