&error(bad_words) if ($badword_found == 1);

[download]
Note that you are calling error with the bareword bad_words, not the variable $badwords. (Yet another of many reasons to use strict; use warnings—but many people have pointed out that this looks Perl 4-ish, and I guess that these pragmata weren't available then.) Thus, your error subroutine is always called.

UPDATE: Immediately after posting, I saw that I'd completely ignored the trailing if ..., so your error routine need not always be called after all. Still, you probably don't want to call it this way.

In reply to Re: Need help with badwords routine by JadeNB
in thread Need help with badwords routine by htmanning

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.