Almost.
- You forgot to convert the text to a regexp pattern.
- You only replace the first instance.
- And since I'm already changing the line, I'll remove the useless use of map.
$text =~ s/\Q$_\E/$fixers{$_}/g
for keys %fixers;
It could still be improved if it's going to be done repeatedly.
my ($re) = map qr/$_/,
join '|',
map quotemeta,
keys %fixers;
while (...) {
...
$text =~ s/$re/$fixers{$_}/g
for keys %fixers;
...
}
Or even better for pre-5.10
use List::Regexp qw( );
my $re = List::Regexp->new()->list2re( keys %fixers );
while (...) {
...
$text =~ s/$re/$fixers{$_}/g
for keys %fixers;
...
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.