what's wrong with this? 

my $first   = shift || die "first file\n";
my $sec     = shift || die "second\n";

[download]

The  || operator has higher precedence than the  = operator so you need to either enclose the assignment in parentheses or use the lower precedence  or operator.

You can accomplish the same result more simply with a single hash: 

#!/usr/bin/perl
use strict;
use warnings;

my $first = shift or die "first file\n";
my $sec   = shift or die "second\n";

open my $FIRST, '<', $first or die "$first: $!";
open my $SEC,   '<', $sec   or die "$sec: $!";

print "processing $first\n";
my %common = map { /^\s*(\?.*?)\s/, 0 } <$FIRST>;

print "processing $sec\n";
/^\s*(\?.*?)\s/ and $common{ $1 }++ while <$SEC>;

print "finding common keys\n";
delete @common{ grep !$common{ $_ }, keys %common };

print "there are @{[scalar keys %common]}:\n";
system 'pause';
for my $key ( keys %common ) {
    print "\n\n\n$key\n\n\n";
    }

[download]

In reply to Re: what's wrong with this? by jwkrahn
in thread what's wrong with this? by Alien

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.