Greetings, fellow monks. I was interviewed recently for a perl role, and they asked me to put together an object. I used my standard new() function (which I've been using for about, gosh, 10 years now), only to find that the interviewers thought it was wrong. Here's the code I wrote: 
    package Bob::MyObject;
    use strict;
    
    sub new {
        my $proto = shift;
            my $class = ref($proto) || $proto;
            my $self  = {
                    command       => undef
             };
             bless ($self, $class);
             return $self;       
    }

[download]
I guess my question is this: what's wrong with this, and how can I improve it? (I'd always thought that this was a pretty standard way of putting a class together, and was very surprised by the interviewer's reaction, to be honest!).

In reply to new() function: incorrect? by lukeyboy1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.