Here are some improvements I would make:
- use warnings; use strict;
- Use lexical filehandles $fh.
- Use the 3-argument form of open
- Check the return value of open with die
- Check for 'Debit' immediately
- Use eq instead of a regex to check for 'Debit'
- Just grab the 7th element from the array returned by split
- Eliminate most of those concatenation operators
- close the file
use strict;
use warnings;
use File::Glob;
my @files = glob("C:/Wire/*.csv");
for my $file (@files) {
open my $fh, '<', $file or die "can not open file $file: $!";
while (<$fh>) {
next if (substr($_,0,5) eq 'Debit');
my $row6 = (split /,/)[6];
print "{1100}02P N", $row6, "{1110}{1120}{1510}{1520}{3320}{3400
+}{3600}{4320}{5000}\n";
}
close $fh;
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.