I need to:

1) open a file
2) print stuff to file
3) call a subroutine that also prints to that file

So I thought I ought to do it like this: 

my $filepath = 'foo.txt';
open my $FOOFILE, '>>', $filepath or die "Couldn't open $filepath \n";
print $FOOFILE "First line of text.\n";


for ( my $outer_loop = 1 ; $outer_loop <= 5 ; $outer_loop++ ) {

    #do a bunch of stuff

    &do_other_stuff;

    if ( $outer_loop == 5 ) {
        print $FOOFILE "The end.";
        close $FOOFILE;
    }

}

sub do_other_stuff {

    for ( my $inner_loop = 0 ; $inner_loop < 5 ; $inner_loop++ ) {

        if ( $inner_loop == 3 ) {
            print $FOOFILE "A match!\n";
        }

    }

[download]
My question is whether this is poor form. Should I close and reopen the file in the sub instead of just leaving it open? More like this: 
sub do_other_stuff {

  open $FOOFILE, '>>', $filepath or die "Couldn't open $filepath \n";

    for ( my $inner_loop = 0 ; $inner_loop < 5 ; $inner_loop++ ) {

        if ( $inner_loop == 3 ) {
            print $FOOFILE "A match!\n";
        }

    }
    close $FOOFILE;
}

[download]
Thanks,

zod

In reply to Keep file open for sub call? by zod

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.