if ( $_ =~ /^NEW YORK:\s+(\S+)/ ) { $newyork = $1; $newyork = $newyork || 'NA'; next; }

(\S+) will always match at least one character and unless you have a team named '0' (the digit zero) then 'NA' will never be assigned.

How about like this UNTESTED:

#!/usr/bin/perl use warnings; use strict; my %lookup = ( 'NEW YORK' => 1, 'MIAMI' => 1, ); my %data; while ( <DATA> ) { next unless /^([^:]+):\s+(\S+)/ && $lookup{ $1 }; $data{ $1 } = $2; } __END__ NEW YORK: knicks CHICAGO: bulls MIAMI: heat LA: lakers

In reply to Re: Please fix my writing style by jwkrahn
in thread Please fix my writing style by convenientstore

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.