Yep, moving that block saves an awful lot of time - as I said, with the block moved, you open the records.txt once only - c/w once per file.

As far as the uninit value is concerned, try... 

use File::Find;
my $DIR = "/tmp/logs/";

open(RECORDS, "/tmp/logs/records.txt") or die "Could not open records 
+file: $!";
local $/ = undef; # Ignoring binmode as its a text file
my $RE = join '|', <RECORDS>;
close RECORDS;

find(\&queries, $DIR);

[download]
Oops, sorry, my fault - as shown, the $RE lexical variable wasn't defined until after use (by the queries sub).

A user level that continues to overstate my experience :-))

In reply to Re^3: Not sure what I am doing wrong by Bloodnok
in thread Not sure what I am doing wrong by learningperl01

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.