By the way, putting your code in <c>...</c> tags will simplify things for both you and us.

Applying ysth's advice, we get: 

#!/usr/bin/perl
use strict;
use warnings;

my $non_running = 0;
my @zones = qx{zoneadm list -ip};

foreach (@zones) {
   my ($id, $name, $state) = split(/:/, $_);
   if($state eq "running") {
      print "OK: zone $name is in running state\n";
   } else {
      print "CRITICAL: Zone $name is in $state\n";
      $non_running = 1;
   }
}

if ($non_running) {
   exit 2;
} else {
   exit 0;
}

[download]

Hopefully, you've learned about else in the process.

In reply to Re^3: Exit values by ikegami
in thread Exit values by farhan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.