my $rand_position = $positions_ref->[ rand( $#{$positions_ref} ) ];
   my $rand_location = $locations_ref->[ rand( $#{$locations_ref} ) ];

[download]

You have an off-by-one error on those array subscripts.   'in the kitchen' will never be chosen from @locations and 'reclining' will never be chosen from @positions.

I would write it more like this: 

#!/usr/bin/perl
use strict;
use warnings;

my @positions = qw( sitting standing reclining );
my @locations = ( 'at the museum', 'in the woods', 'on the beach', 'in
+ the kitchen' );
my @drinks    = qw( scotch beer coke yoohoo );

1 while do_it( print_options( \@drinks ), \@positions, \@locations );

sub print_options {
    my $drinks_ref = shift;

    for my $i ( 0 .. $#$drinks_ref ) {
        print $i + 1, ". $drinks_ref->[$i]\n";
        }

    my $selection;
    do  {
        print 'Choose a number: ';
        chomp( $selection = <STDIN> );
        } until $selection >= 1 && $selection <= @$drinks_ref;

    return $drinks_ref->[ $selection - 1 ];
    }

sub do_it {
    my ( $drink, $positions_ref, $locations_ref ) = @_;
    my $rand_position = $positions_ref->[ rand @$positions_ref ];
    my $rand_location = $locations_ref->[ rand @$locations_ref ];

    print "You just drank a $drink $rand_location in the $rand_positio
+n position.\n";

    if ( $rand_location eq 'on the beach' ) {
        print "YEEEEEHAAAWWWWWWWWWW!\n";
        return 0;
        }
    return 1;
    }

[download]

In reply to Re: Repeating an input prompt by jwkrahn
in thread Repeating an input prompt by zod

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.