You want to read the file only once and look for both strings. You don't care whether the second is found when the first is not found, but it's probably cheaper to look for both from the beginning rather than go back and reread the file when it's time to look for the second string.

What you're doing right now is looking for the second string only on lines that contain the first string.

sub edits { return if ! -f; return if ! /^Khlog.08$/; open my $log_fh, '<', $_ or die "Can't read '$File::Find::name': $!"; my ( $found1, $found2 ); while ( defined( my $line = <$log_fh> ) ) { $found1 = $found1 || ( $line =~ /002389983/ ); $found2 = $found2 || ( $line =~ /29994339499/ ); last if $found1 && $found2; } }

In reply to Re: How to search for two strings/regex in one file by kyle
in thread How to search for two strings/regex in one file by learningperl01

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.