First, you should always use strict; and use warnings;. Second, you should use lexical file handles. Third, you can perform this in one loop over the file. And fourth, you can use unlink to delete the file, and rename to rename the temp file.

This should do what you want:

#!/usr/bin/perl use strict; use warnings; open my $file, "<", "petpages" or die "Could not open petpages: $!"; open my $new, ">", "petpages.new" or die "Could not open petpages.new: + $!"; while (my $line = <$file>) { $line =~ tr/A-Z/a-z/; print $new "http://$line"; } close $file; close $new; rename "petpages.new", "petpages";

Update:I forgot to mention that exec doesn't do what you think. As the first line in the doc says, exec never returns. That is why you got the warning: Statement unlikely to be reached at c.pl line 11. (Maybe you meant system() when you said exec()?). Since the rest of the code is never executed, that is why the "http://" never gets prepended.


In reply to Re: File manipulation only works when I split it into two files. by lostjimmy
in thread File manipulation only works when I split it into two files. by Vonunov

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.