On the BEGIN block issue. tye and I disagree quite emphatically on that, see the discussion starting at Re (tilly) 1: Supersplit for details. Suffice it to say that I would drop that block, and move strict to after the initial declarations.

On a more important note, my does not do what vars does. Things like @ISA, @EXPORT_OK, etc need to be global, not lexical. Either move strict to after them, or else declare with vars. my simply will not work.

Thirdly your method/no method code has a lot of repeated logic in it. I would recommend replacing it by something that looks like this: 

  my $self = ref($_[0]) ? shift : $default_self;

[download]
This also allows you to move the my declarations to the first use of the variables. Stylistically I prefer this for lexicals.

For more of my philosophy on scoping see RE (tilly) 3: redeclaring variables with 'my'.

In reply to Re (tilly) 1: Morse::Code by tilly
in thread Morse::Code by crazyinsomniac

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.