#look for files in $DIR
sub collect_files {
    opendir(DIR, "$DIR");
    while (defined(my $file = readdir(DIR))) {
        if ( ! -d $file ) { &check_mime_type($file); }
    }
    closedir(DIR);
}


#collect files, create thumbnails and pass list of images back to cgi 
+output
sub collect_thumbs {
    &collect_files;
    my @thumbs;
    opendir(DIR, "$DIR/thumbs");
    while (defined(my $file = readdir(DIR))) {
        if ( ! -d $file ) { push(@thumbs, $file); }
    }
    closedir(DIR);
    return @thumbs;
}

[download]

readdir gives you a file name from the directory $DIR (or "$DIR/thumbs") but you are not testing the file in that directory ( ! -d $file ), you are testing it in the current directory.   You need to prepend the directory name to the file name to test the correct file.

You should also always verify that open, opendir and unlink worked correctly.

See also: What's wrong with always quoting "$vars"?

In reply to Re: Thumbnail autoindex by jwkrahn
in thread Thumbnail autoindex by ScOut3R

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.