I have got couple of comments to be updated

<?xml version="1.0" encoding="ISO-859-1"?>
>>encoding information is wrong, that should be a typo to ISO-8589-1

opendir(DIR, ".");
>> return status should be checked
>> opendir(DIR, ".") or die "Unable to open directory <$!>\n";

closedir(DIR);
>> closing the directory also might fail, its better to check the return status
>> closedir(DIR) or die "Unable to close the directory <$!>\n";

while ($a ne "y")
>> What if the user is not interested to process the xml files. This seems to be forcing user to select an option to process the files
>> If this is going to be modified in such a way that user can input either "y" or "n", then prefetching of xml files into array should be done only after based on user's input

$a = <STDIN>;    chop $a;
>> I think this is better chomp( $a = <STDIN );

my $xs1 = XML::Simple->new();
>> there is no need to create an object for each and every file
>> same thing applies to other objects repeatitively created where just one instance can be made use of.

In reply to Re: Thanks !! (XML + Excel) with (win32::OLE and XML::Simple) by matrixmadhan
in thread Thanks !! (XML + Excel) with (win32::OLE and XML::Simple) by Sporti69

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.