Hey guys,
I am extremely new to perl, about a month into it, and have written an application that works without issue, however I would love to clean it up with some for or foreach loops, and would like to hear some suggestions...
Here is a blurb from my code that I would like cleaned up:
if (scalar@row1 == "6")
{ @entry1 = (@required , @row1);
$digest1 = sha1_hex(@entry1);
$sth = $dbh->prepare($query);
$sth->execute($digest1);
$data1 = $sth->fetchrow_array();
if ($data1 ne $digest1) {
push(@entry1, $digest1);
$sth = $dbh->prepare($insert);
$sth->execute(@entry1);
&create_pdf(@entry1);
$msg->attach(
Type => 'image/gif',
Path => "../pdfs/ir_$diges
+t1.pdf",
Filename => "ir_$digest1.pdf",
Disposition => 'attachment')
} else {$dberr
+or .= "The following row you submitted: <br> @entry1 <br>already exsi
+ts in the database and will note be re-submitted. <br>"}
};
My dilemma is that I have repeated this code 5 times changing only the numbers at the end of my arrays and variables which is where I would like the for loop to come in so I would only need to have the one iteration.
Thanks in advance for any and all suggestions/help!
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.