Before you do anything else add strictures (use strict; use warnings;) to your code. On the face of it all variables you are worried about except $row1 are local to the if block so their names don't matter. It may be there is a whole lot more context that is pertinent, but you haven't shown it.

Aside from that if (scalar@row1 == "6") is not right and doesn't make sense. It isn't right because == compares numbers, but "6" is a string. It doesn't make sense because there is not enough context to figure out where @row1 comes from and why it should have 6 elements. It needs to make sense before it can be refactored.

Perl's payment curve coincides with its learning curve.

In reply to Re: Cleaning up Code by GrandFather
in thread Cleaning up Code by atmosphere

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.