You're ignoring the result of the recursive call.
&spl($total) if ($len != 1);
should be
$total = &spl($total) if ($len != 1);
Now, what we have here what is called tail-end recursion. The recursion is the last thing in the function. That means you can use a loop instead.
sub spl {
my ($num1) = @_;
while (1) {
my $total = 0;
$total = $total + $_ for (split '', $num1);
my $len = length ($total);
if ($len == 1) {
return $total;
}
$num1 = $total;
}
}
After some cleaning up, we get:
sub spl {
my ($n) = @_;
while (length($n) > 1) {
my $total = 0;
$total = $total + $_ for split '', $n;
$n = $total;
}
return $n;
}
or even
use List::Util qw( sum );
sub spl {
my ($n) = @_;
while (length($n) > 1) {
$n = sum split '', $n;
}
return $n;
}
Update: Added last snippet.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.