Yes, that's fine, but. It would be more useful to ask "will this give me the output I want" (with a sample output provided) rather than "is this code OK". This is the equivalent of saying "perl -c reports no syntax errors - guess it works!" instead of "my tests pass - guess it works!".

  1. Do you want to use the # as a delimiter in the array?
  2. Do you want to throw out any '#' entries?
  3. Is there some other result that I haven't guessed?
To make sub-arrays at each '#':
use strict;
use warnings;
use Data::Dumper;

my @broken_up;
my @array = qw( 1 2 3 # 4 5 # 6 7 8 9 # 10);
my $position = 0;
$broken_up[0] = [];
foreach my $item (@array) {
  if ($item eq '#') {
    $position++;
    $broken_up[$position] = [];
  }
  else {
    push @{ $broken_up[$position] }, $item;
  }
}

print Dumper(\@broken_up);

[download]
gives 
$VAR1 = [
          [
            '1',
            '2',
            '3'
          ],
          [
            '4',
            '5'
          ],
          [
            '6',
            '7',
            '8',
            '9'
          ],
          [
            '10'
          ]
        ];

[download]
Now you have an array of arrays, broken at the '#'s. (The extra level of nesting is because I dumped a reference to the output array.)

If you just want to throw the '#'s out: 

@array = qw( 1 2 # 3 4 5 # 6 7 8 9 # 10);
@array = grep { $_ ne '#' } @array;
print "@array\n";

[download]
gives 
1 2 3 4 5 6 7 8 9 10

[download]
Notice that these are wildly different, because we don't know what you're actually trying to do. Obviously it doesn't matter whether or not the style is good ... if the result is wrong. :)

In reply to Re^3: Is this bad coding style? by pemungkah
in thread Is this bad coding style? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.