This is good but I think it may be overload overwhelming. I think what he needs is to see what's wrong with his script before we show any tricks ( i know, standard perl ).

For example, show how his script can be made to work as close to what it is right now.

What is probably happening is that you're getting errors about undeclared symbols, like %seen, for example.

Also what you need to do is separate the stage where you read in the lines, and the place where you do something with them, like identify the unique ones.

The following example may get closer to what you want, it still will have errors.. 

#! C:\Perl\bin\perl.exe
use strict;

my $file = "controls.txt";
open (FH, "< $file") or die "Can't open $file for read: $!";

my @lines;
while (<FH>) {
    push (@lines, $_);
}

my %seen = ();
my @uniq = ();
foreach @lines {
        unless ($seen{$item}) {
                #if we get here, we have not seen it before
                $seen{$item} = 1;
                push(@uniq, $item);
        }
}

close FH or die "Cannot close $file: $!";
print @lines;    # see if it worked

[download]

Remember, every symbol ($variable_name) must be given a scope(range of where in the code it is valid), with my. You can't just introduce a $item variable if it has not been declared and scoped. Which is what you are correctly doing with my @lines, and my $file, etc..

In reply to Re^2: finding unique items in an array, from a text file by leocharre
in thread finding unique items in an array, from a text file by spazmospazmo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.