Hi
I have an excel file report where i need to traverse through each row and check if a certain
column matches a regular expression (MSD) and another match as well....
My code does it...but i'm looking for a better way to do it
Can you guys look at the code and suggest some performance boosters to the code?
my $CB_COUNT = 0;
my $NM_COUNT = 0;

my $LastRow = $Sheet->UsedRange->Find({What=>"*",
    SearchDirection=>xlPrevious,
    SearchOrder=>xlByRows})->{Row};

my $LastCol = $Sheet->UsedRange->Find({What=>"*", 
                  SearchDirection=>xlPrevious,
                  SearchOrder=>xlByColumns})->{Column};
                  
                  print $LastRow."  and last column   ".$LastCol;


for $i (1 .. $LastRow)
{
    my $rango5 = "E".$i;
    my $rango6 = "J".$i;
    if ($Sheet->Range("$rango5")->{Value} !~ /MSD/)
    {
        $CB_COUNT++;
    }
    if ($Sheet->Range("$rango5")->{Value} !~ /MSD/ && $Sheet->Range("$
+rango6")->{Value} !~ /No_/i)
    {
        $NM_COUNT++;
    }
}

[download]
UPDATE:
Change in the code... 
my $CB_COUNT = 0;
my $NM_COUNT = 0;

$LastRow = $Sheet->UsedRange->Find({What=>"*",
    SearchDirection=>xlPrevious,
    SearchOrder=>xlByRows})->{Row};

my $LastCol = $Sheet->UsedRange->Find({What=>"*", 
                  SearchDirection=>xlPrevious,
                  SearchOrder=>xlByColumns})->{Column};
                  
                  print $LastRow."  and last column   ".$LastCol;


for $i (1 .. $LastRow)
{
    my $rango5 = "E".$i;
    my $rango6 = "J".$i;
#    my $rango7 = "
    if ($Sheet->Range("$rango5")->{Value} !~ /MSD/)
    {
        $CB_COUNT++;
        if($Sheet->Range("$rango6")->{Value} !~ /No_/i)
        {
            $NM_COUNT++;
        }
    }
}

[download]
Raghu

In reply to Win32::OLE & Excel help by imrags

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.