Here are some comments to your code:
- You don't need to open the input file before passing it to $extor->parse_file
- Use the glob function (glob("./*.html)) instead of readdir and parse the resulting files for the ".html" extension
- You are not extracting the links (you are not using the method $extor->links)
- You are using $_ inside the foreach loop, but that variable is not initialized (because you are using a "loop variable" ($file))
- $file is declared outside the foreach loop, you should avoid this and restrict the scope of the variable at the minimum
- You should get the habit of closing the filehandles
Here is a version of your code with all these issues corrected (untested):
use strict;
use warnings;
use HTML::SimpleLinkExtor;
my $FileOut = "output.txt";
open FileDOut, ">$FileOut" or die "Can't open output file $FileOut: $!
+";
print "Summary written in file $FileOut\n";
while (my $file = glob ("*.html")){
print FileDOut "$file\n";
my $extor = HTML::SimpleLinkExtor->new();
$extor->parse_file($file);
my @links = $extor->links();
print FileDOut "$_\n" for (@links);
print FileDOut "\n";
}
close FileDOut;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.