Using ifs in conjunction with last and an anonymous block is just weird. An if/elsif cascade is clearer and more efficient:

sub count_separators { my $value = shift; my $delim = shift; my $set; if ($delim eq '{') { $set = '{|}'; } elsif ($delim eq '(') { $set = '(|)'; } elsif ($delim eq '"') { $set = '"'; } else { die; # Should never occur... } print 'sub { return shift =~ tr/' . $set . '//; }' . "\n"; return eval 'sub { return shift =~ tr/' . $set . '//; }'; }

If you really want to use the obscure fabricated switch statement, do it right :)

sub count_separators { my $value = shift; my $delim = shift; my $set; { $delim eq '{' and $set = '{|}' and last; $delim eq '(' and $set = '(|)' and last; $delim eq '"' and $set = '"' and last; die; # Should never occur... } print 'sub { return shift =~ tr/' . $set . '//; }' . "\n"; return eval 'sub { return shift =~ tr/' . $set . '//; }'; }

But, given that you have only hardcoded sets, even though you have several of them, bringing eval into the equation is completely unnecessary.

This is far simpler and more efficient:

sub count_separators { my $value = shift; my $delim = shift; $delim eq '{' and return $value =~ tr[{|}][]; $delim eq '(' and return $value =~ tr[(|)][]; $delim eq '"' and return $value =~ tr["][]; #"; die; }

Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.
"Too many [] have been sedated by an oppressive environment of political correctness and risk aversion."

In reply to Re: count number of occurrences of specific character(s) in a string by BrowserUk
in thread count number of occurrences of specific character(s) in a string by dHarry

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.