The Perl::Critic policy in question is Perl::Critic::Policy::ControlStructures::ProhibitMutatingListFunctions. It implements the policy recommendation from page 114 of PBP, which suggests that if you really need to do what you're doing, make a lexical variable. 

my @files
    = map {
        my $file = $_;
        chomp $file;
        $file =~ s{ \A \s+ | \s+ \z }{}xmsg;
        $file;
    } <$FILES>;

[download]

It goes on to say that if you really do want a side-effect of your loop, use for instead.

Perhaps merlyn's use of local (as in modifying $_ in map (was Re: A perverse use of grep)) should be allowed by the policy. I don't think so, but I could see that being an option. In any case, rt://Perl::Critic might be a good place to make that case.

In reply to Re: PerlCritic, $_ and map by kyle
in thread PerlCritic, $_ and map by chexmix

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.