Hello, I'm writing a perl script to rename some old log file with the date the file was last modified to be in the file name. Example: maillog.1.gz rename to maillog.20090213.gz. Here's what I have written so far. It sorts the files newest to oldest and then prints the new filename with the mtime, replacing the digit between maillog and gz. I'm not very experienced with perl, so I'm looking for advice if what I have written is any good and how it could be improved. Thanks for your help! 
#!/usr/bin/perl -w

use strict;
use File::stat;
use POSIX qw(strftime);

my $maillog_dir = '/var/log/maillogs';

opendir ( LOG, $maillog_dir) or die ("Can't open $maillog_dir: $!");
my @list = sort { -M "$maillog_dir/$a" <=> -M "$maillog_dir/$b" }
        grep { -f "$maillog_dir/$_" }
        readdir ( LOG );

foreach my $file ( @list ){
        my $datestamp = strftime("%Y%m%d", localtime(stat("$maillog_di
+r/$file")->mtime));
        $file =~ s/\d+/$datestamp/;
        print "$file\n";
}
close ( LOG );

[download]

In reply to rename files with mtime by pbaumgar

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.