I have a web app where I'm testing all input for validity. All is fine and dandy except testing file input has me perplexed. I'm testing the file input for a valid file pattern (something like \\servername\folder\etc\file.ext or c:/folder/etc/file.ext), but firefox doesn't return the entire file path, just the file name. Here's my file validation code:
sub untaintFile{
my $text=$_[0];
if (defined $text && $text ne ''){
if ($text =~ /^(\w\:([\\\/][\w\s\]+[\w\s\-\.\']*\.?[\w
+\s]*)*)$/ ||
$text =~ /^(\\([\\\/][\w\s\]+[\w\s\-\.\']*\.?[\w\s
+]*)*)$/ ) {
$text = "$1";
} else {
...code for sending me an email...
$text = "";
}
}
return $text;
}
Should I just forget the pattern match and just test that there aren't any funky characters? What all should I be allowing? Does anyone have some suggestions for me?
I'm not a unix or security expert by any stretch, so i'm not exactly sure what I should consider 'safe'. Everything I've found so far on validating input is very vague and non-specific, just that good practice is to have a whitelist and not allow anything except your whitelist.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.