Here's a few checks you could easily add:

It looks like you're assuming that it's a text file, and you read it into memory line by line. But what if someone accidentally sends you a large binary file (maybe it's the correct file, only it's been zipped)?

Here's a revised version of your upload() function that uses read() to read the file into a buffer 1kb at a time, and abort if it looks too big (you can set your own limit). 

sub upload {
  my $self = shift;
  my $q = $self->query;
  if(untaintFile($q->param('file')) && $q->upload('file')) {
    my $filename=untaintFile($q->param('file'));
    ($filename) = $filename =~ /([[:ascii:]]+)/;

    unless($filename) {
      croak "no filename given!";
    }

    my $file = $q->upload('file');

    unless($file) {
      croak "can't get filehandle for upload!";
    }

    my $data;
    my $buffer;
    my $bytesread = 0;
    my $totalbytes = 0;

    while($bytesread = read($file, $buffer, 1024)) {
      $totalbytes += $bytesread;
      if($totalbytes > $MAX_DATA_LIMIT) {
        croak "upload file too big!";
      }
      $data .= $buffer;
    }

    unless ($data) {
      croak "no data!";
    } else {
      my $thisfile = File->parse($data);
                        
      if(my $format_error = $thisfile->check_formatting()) {
        # warn if any format errors found
      return;
                        }
      my $file_id = $self->file_upload({
        name => $filename, 
        data => $data,
      });
    }
  }
  $self->header_type('redirect');
  $self->header_props(-url => "$CONFIG{userbase}/user.pl");
  return;
}

[download]

In reply to Re^3: Testing file input validity in FF by scorpio17
in thread Testing file input validity in FF by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.