You used it wrong, but I see I used the wrong prototype, and my "if $keep" disappeared.

use strict; use warnings; sub grep_in_place(&\@) { my ($cb, $array) = @_; my $src = -1; my $dst = -1; while (++$src < @$array) { my $keep; $keep = $cb->() for $array->[$src]; $array->[++$dst] = $array->[$src] if $keep; } $#$array = $dst; } my @a = (1,2,3,4,5,6,7,8); print("Before: @a\n"); grep_in_place { $_ > 4 } @a; print("After: @a\n");
Before: 1 2 3 4 5 6 7 8 After: 5 6 7 8

To get your (and probably the OP's) semantics:

sub grep_and_remove(&\@) { my ($cb, $array) = @_; my $src = -1; my $dst = -1; my @deleted; while (++$src < @$array) { my $keep; $keep = $cb->() for $array->[$src]; ($keep ? $deleted[@deleted] : $array->[++$dst] ) = $array->[$src]; } $#$array = $dst; return @deleted; } my @a = (1,2,3,4,5,6,7,8); print("Before: @a\n"); my @b = grep_and_remove { $_ > 4 } @a; print("After: @a\n"); print("Returned: @b\n");
Before: 1 2 3 4 5 6 7 8 After: 1 2 3 4 Returned: 5 6 7 8

No crazy splice!


In reply to Re^3: Fastest way to grep multiple time on some array by ikegami
in thread Fastest way to grep multiple time on some array by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.