A couple of thoughts further to ELISHEVA's comments.

• The normal convention is to use x to represent left and right and y for up and down. You might want to swap your $x and $y to avoid confusion.

• Rather than employing a for loop to iterate over every line you want to print, consider printing your "solid" top border then using the for to iterate over 2 fewer lines than your total y dimension whilst printing the "hollow" lines then finally printing the "solid" bottom border. That way, you have no need to detect where you are in the loop.

• Consider putting this code in a subroutine, passing your dimensions as arguments (see perlsub) as a further learning exercise. Think about doing some basic validation, e.g. how would you cope with a negative or non-numeric dimension?

I hope these thoughts are helpful.

Cheers,

JohnGG

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.