open (OUTPUT, ">$fname.tmp"); open (DATA, "$fname");

You should always verify that the file opened correctly before trying to use a possibly invalid filehandle.

open OUTPUT, '>', "$fname.tmp" or die "Cannot open '$fname.tmp +' $!"; open INPUT, '<', $fname or die "Cannot open '$fname' $!";

$offset = 0; while (read(DATA, $data, BLOCKLEN, $offset)) { my $blockhdr = unpack "H*", substr($data, 0, BLOCKHDR) +; my $blockdt = unpack "H*", substr($data, BLOCKHDR, BL +OCKDATA); my $cdrdata = unpack "H*", substr($data, BLOCKHDR+BLO +CKDATA, CDRLENGTH); ... $offset += BLOCKLEN; ... $offset += BLOCKLEN; $offset -= 286;

$offset is the position in $data where the data is copied from the file but you are not capturing the actual number of bytes read and just assuming that it is always BLOCKLEN number of bytes.   So each time through the loop you are appending records to the end of $data but you are always reading from the beginning of $data.

my $total_record = hextoint(reverse_str(substr($blockd +t,4)));

What does reverse_str do that reverse cannot do?   What does hextoint do that unpack or hex cannot do?


In reply to Re: How to read number of block in binary files? by jwkrahn
in thread How to read number of block in binary files? by bh_perl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.