koolgirl:

Just a minor note: You're opening & closing the output file handle repeatedly, which can be pretty slow if you must do it often. One way you could speed things up is to open the output file handle only once (if required) and close it only once at the end. Something like:

# First declare your file handle
my $OUT;
...
foreach ... {
   while ... {
      if ... {
         # Error found, so...

         # open the file if not open yet
         if (!defined $OUT) {
            open $OUT, '>', "$path/$file" or die "Uggabug! $!";
         }

         # and log the error
         print $OUT "Yer error message\n";
      }
   }
}
# finally, close it if you've opened it
close($OUT) if defined $OUT;

[download]
...roboticus

In reply to Re: File not opening, but no error report by roboticus
in thread File not opening, but no error report by koolgirl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.